Fix typos in CONTRIBUTING #347
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Morgan Bazalgette <[email protected]>
tboerger
reviewed
Dec 4, 2016
| @@ -24,17 +24,17 @@ This process gives everyone a chance to validate the design, helps prevent dupli | |||
|
|
|||
| ## Testing redux | |||
|
|
|||
| Before sending code out for review, run all the tests for the whole tree to make sure the changes don't break other usage and keep the compatibility on upgrade. To make sure you are running the test suite exactly like we do you should install the CLI for [Drone CI](https://github.com/drone/drone) as we are using the server for continous testing, follow [these instructions](http://readme.drone.io/0.5/install/cli/). After that you can simply call `drone exec` within you working directory and it will try to run the test suite locally. | |||
| Before sending code out for review, run all the tests for the whole tree to make sure the changes don't break other usage and keep the compatibility on upgrade. To make sure you are running the test suite exactly like we do you should install the CLI for [Drone CI](https://github.com/drone/drone), as we are using the server for continous testing, following [these instructions](http://readme.drone.io/0.5/install/cli/). After that you can simply call `drone exec` within you working directory and it will try to run the test suite locally. | |||
There was a problem hiding this comment.
There had been a typo even before: within your working directory and it will try to run the test suite locally.
| * Don't make changes unrelated to your PR. Maybe there are typos on some comments, maybe refactoring would welcome on a function... but if that is not related to you PR, please make *another* PR for that. | ||
| * Split big pull requests in multiple. An incremental change will be faster to review than a huge PR. | ||
| * Don't make changes unrelated to your PR. Maybe there are typos on some comments, maybe refactoring would be welcome on a function... but if that is not related to your PR, please make *another* PR for that. | ||
| * Split big pull requests in many small ones. An incremental change will be faster to review than a huge PR. |
There was a problem hiding this comment.
I would say multiple instead of many
|
After merging that we should copy the changes to all our other repos. |
tboerger
added
the
lgtm/need 2
|
👍, applied corrections |
|
LGTM |
tboerger
added
lgtm/need 1
|
LGTM |
tboerger
added
lgtm/done
|
LGTM |
1 similar comment
|
LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apart from fixing some normal mistakes, like mistakenly using plural have where the subject is singular, I have also changed instances of "he" to use the singular they, so that it's more gender-inclusive.
Only exception is "If an owner don't obey these rules, the others are allowed to revoke his owner status.", in which I've retained his because in my opinion "If an owner don't obey these rules, the others are allowed to revoke their owner status." is ambiguous and doesn't make much sense.