Fix the issue of abnormal interface when there is no issue-item on the project page #34791
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
kerwin612
changed the title
wxiaoguang
reviewed
Jun 20, 2025
web_src/css/features/projects.css
Outdated
| @@ -19,6 +19,7 @@ | |||
| } | |||
|
|
|||
| .project-column { | |||
| min-height: max(calc(100vh - 400px), 300px); | |||
There was a problem hiding this comment.
I think min-height: min(100vh, 200px); (or 300px) is better.
There was a problem hiding this comment.
And we should put the styles on #project-board.
It already has max-height: calc(100vh - 120px);
There was a problem hiding this comment.
min-height: min(100vh, 200px);Personally, I feel it's a bit lacking in aesthetics. Of course, the decision is yours.
There was a problem hiding this comment.
Actually GitHub doesn't set min-height. It always make the column full-height
But I think it's fine to use any solution at the moment.
delvh
approved these changes
Jun 20, 2025
GiteaBot
added
lgtm/need 1
wxiaoguang
approved these changes
Jun 20, 2025
GiteaBot
added
lgtm/done
lunny
added
topic/ui
GiteaBot
removed
the
reviewed/wait-merge
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Jun 23, 2025
* giteaofficial/main: (22 commits) [skip ci] Updated translations via Crowdin Fix required contexts and commit status matching bug (go-gitea#34815) Add "Cancel workflow run" button to Actions list page (go-gitea#34817) Use `shallowRef` instead of `ref` in `.vue` files where possible (go-gitea#34813) Edit file workflow for creating a fork and proposing changes (go-gitea#34240) Refactor packages (go-gitea#34777) Refactor wiki (go-gitea#34805) [skip ci] Updated translations via Crowdin Upgrade htmx to 2.0.5 (go-gitea#34809) Forks repository list page follow other repositories page (go-gitea#34784) Add post-installation redirect based on admin account status (go-gitea#34493) Rework delete org and rename org UI (go-gitea#34762) Refactor editor (go-gitea#34780) Improve img lazy loading (go-gitea#34804) [skip ci] Updated translations via Crowdin Fix Feishu webhook signature verification (go-gitea#34788) Upgrade chi to v5.2.2 (go-gitea#34798) Fix the issue of abnormal interface when there is no issue-item on the project page (go-gitea#34791) Fix container range bug (go-gitea#34795) Fix OCI manifest parser (go-gitea#34797) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.