Skip to content

Actually fix 'make build' #353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 5, 2016
Merged

Actually fix 'make build' #353

merged 2 commits into from
Dec 5, 2016

Conversation

bkcsoft
Copy link
Member

@bkcsoft bkcsoft commented Dec 5, 2016

now it only rebuilds on changed files (again), but actually rebuilds when something other than main.go has been changed...

@tboerger
Copy link
Member

tboerger commented Dec 5, 2016

But wildcard should act similar to that :)

@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 5, 2016
@bkcsoft
Copy link
Member Author

bkcsoft commented Dec 5, 2016

@tboerger nope, see #351 (comment)

@Bwko
Copy link
Member

Bwko commented Dec 5, 2016

LGTM

@tboerger tboerger added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Dec 5, 2016
@tboerger
Copy link
Member

tboerger commented Dec 5, 2016

You are right, but maybe you can define it like this?

TARGETS ?= linux/*,darwin/*,windows/*
PACKAGES ?= $(shell go list ./... | grep -v /vendor/)
SOURCES ?= $(...)

...

$(EXECUTABLE): $(SOURCES)
	go build -v -tags '$(TAGS)' -ldflags '-s -w $(LDFLAGS)' -o $@

@bkcsoft
Copy link
Member Author

bkcsoft commented Dec 5, 2016

@tboerger done :)

@strk
Copy link
Member

strk commented Dec 5, 2016

LGTM - thanks for the care !

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 5, 2016
@bkcsoft bkcsoft merged commit 1b5b297 into master Dec 5, 2016
@tboerger tboerger deleted the bkcsoft/fix-rebuilding branch December 5, 2016 18:55
@lunny lunny added this to the 1.0.0 milestone Dec 7, 2016
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/deployment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants