Skip to content

Bug fixes for repo permissions in API #356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 7, 2016
Merged

Bug fixes for repo permissions in API #356

merged 1 commit into from
Dec 7, 2016

Conversation

ethantkoenig
Copy link
Member

Correct repo permissions for the following API endpoints:

  • GET /users/:username/starred
  • GET /user/starred
  • GET /repos/:username/:reponame/
  • GET /repositories/:id

@tboerger tboerger added type/enhancement An improvement of existing functionality topic/security Something leaks user information or is otherwise vulnerable. Should be fixed! labels Dec 6, 2016
@tboerger tboerger added this to the 1.0.0 milestone Dec 6, 2016
@tboerger
Copy link
Member

tboerger commented Dec 6, 2016

LGTM

@tboerger tboerger added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Dec 6, 2016
@bkcsoft
Copy link
Member

bkcsoft commented Dec 6, 2016

Maybe we should have APIFormat take a models.AccessModel instead and put the logic in there?

@ethantkoenig
Bug fixes for repo permissions in API
ba0fcac 
Also move duplicated code into repo.APIFormat(..)
@ethantkoenig
Copy link
Member Author

Updated based on @bkcsoft's suggestion

@bkcsoft
Copy link
Member

bkcsoft commented Dec 7, 2016

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 7, 2016
@bkcsoft bkcsoft merged commit 04b9a7e into go-gitea:master Dec 7, 2016
@ethantkoenig ethantkoenig deleted the api/fixes branch December 7, 2016 15:19
@ethantkoenig ethantkoenig mentioned this pull request Dec 7, 2016
Merged
@lunny lunny added the modifies/api This PR adds API routes or modifies them label Jan 25, 2017
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them topic/security Something leaks user information or is otherwise vulnerable. Should be fixed! type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@ethantkoenig @tboerger @bkcsoft @lunny