Skip to content

Fix column removal in MSSQL (#3638) #3640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

lafriks
Copy link
Member

@lafriks lafriks commented Mar 7, 2018

Backport #3638

* Fix column removal in MSSQL

* Use xorm session in MSSQL drop column operations

* Add transaction as MSSQL alter table is transactional
@lafriks lafriks added this to the 1.4.0 milestone Mar 7, 2018
@tboerger tboerger added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Mar 7, 2018
@lunny
Copy link
Member

lunny commented Mar 7, 2018

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 7, 2018
@lafriks lafriks merged commit 92a3061 into go-gitea:release/v1.4 Mar 7, 2018
@lafriks lafriks deleted the backport/mssql_drop_cols branch March 7, 2018 09:59
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants