avoid os.Setenv calls in runServ, add env vars to gitcmd.Env instead

[ilius]

Using os.Setenv() is the middle of a running program is very unsafe, specially if some vars are set conditionally (their effect will remain until the program is running)

I think the only reason we set these env vars is because of running the git command gitcmd.Run().
Please correct me if I'm wrong.
For the gitcmd.Run(), we just need to add vars to gitcmd.Env, without effecting the global env vars.

EDIT: I realized this part of program does not stay running (and there is no concurrency) because it's compiled to a serv binary and runs for each operation.
But it's still cleaner this way and a better practice in general.

[codecov-io]

Codecov Report

❗ No coverage uploaded for pull request base (master@4b84928). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #3772   +/-   ##
=========================================
  Coverage          ?   37.61%           
=========================================
  Files             ?      310           
  Lines             ?    46040           
  Branches          ?        0           
=========================================
  Hits              ?    17319           
  Misses            ?    26242           
  Partials          ?     2479

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b84928...5817c2e. Read the comment docs.

[thehowl]

I would prefer to avoid using a map and then joning all of its keys (maps are quite expensive to allocate and env vars will always be in random order because of how range works on maps) - can't you use a bytes.Buffer instead?

[ilius]

I changed it to []string, the same thing that we need to give to the command (gitcmd.Env)

[thehowl]

... and make these buf.WriteString(models.EnvRepoUsername + "=" + username + "\n") etc. instead?

[ilius]

We will need to convert it to []string at the end (strings.Split). I don't think using buffer is worth it (we don't set too many env vars)

[stale]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 months. Thank you for your contributions.

[stale]

This pull request has been automatically closed because of inactivity. You can re-open it if needed.