Make Generate New Token panel shown by default #3832
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is mostly a 'feel' change. The behaviour that is currently on the access tokens pages is, as far as I know, not present in any other parts of the frontend, and there's no real good reason to keep the 'Generate New Token' panel hidden by default in my opinion.
Codecov Report
@@ Coverage Diff @@
## master #3832 +/- ##
==========================================
- Coverage 20.23% 20.22% -0.02%
==========================================
Files 145 145
Lines 28997 28997
==========================================
- Hits 5867 5864 -3
- Misses 22240 22242 +2
- Partials 890 891 +1
Continue to review full report at Codecov.
|
bkcsoft
added
the
lgtm/need 2
bkcsoft
approved these changes
Apr 29, 2018
bkcsoft
added
lgtm/need 1
lafriks
approved these changes
Apr 29, 2018
bkcsoft
added
lgtm/done
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mostly a 'feel' change. The behaviour that is currently on the
access tokens pages is, as far as I know, not present in any other parts
of the frontend, and there's no real good reason to keep the 'Generate
New Token' panel hidden by default in my opinion.