Skip to content

Switch back to upstream goth repository and update govendor to latest goth version #3863

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 30, 2018
Merged

Switch back to upstream goth repository and update govendor to latest goth version #3863

merged 1 commit into from
Apr 30, 2018

Conversation

lafriks
Copy link
Member

@lafriks lafriks commented Apr 29, 2018

As title

@lafriks lafriks added this to the 1.5.0 milestone Apr 29, 2018
@lafriks lafriks force-pushed the fix/dep_update_goth branch from f66b37b to d858ff3 Compare April 29, 2018 21:53
@codecov-io
Copy link

codecov-io commented Apr 29, 2018 •
edited
Loading

Codecov Report

Merging #3863 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3863      +/-   ##
==========================================
+ Coverage   20.22%   20.23%   +0.01%     
==========================================
  Files         145      145              
  Lines       28997    28997              
==========================================
+ Hits         5864     5867       +3     
+ Misses      22242    22240       -2     
+ Partials      891      890       -1
Impacted Files Coverage Δ
modules/process/manager.go 73.91% <0%> (+4.34%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f62d4f...d858ff3. Read the comment docs.

@bkcsoft bkcsoft added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 29, 2018
@thehowl
Copy link
Contributor

thehowl commented Apr 29, 2018

LGTM

@bkcsoft bkcsoft added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 29, 2018
@bkcsoft bkcsoft added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 30, 2018
@appleboy appleboy merged commit ff64f18 into go-gitea:master Apr 30, 2018
@lafriks lafriks deleted the fix/dep_update_goth branch April 30, 2018 16:37
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@appleboy appleboy appleboy approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/miscellaneous
Projects
None yet
Milestone
1.5.0
Development

Successfully merging this pull request may close these issues.
5 participants
@lafriks @codecov-io @thehowl @appleboy @bkcsoft