Skip to content

Fix blank topic on explore repo list #3956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 13, 2018
Merged

Fix blank topic on explore repo list #3956

merged 2 commits into from
May 13, 2018

Conversation

techknowlogick
Copy link
Member

@techknowlogick techknowlogick commented May 12, 2018

As title

Here's what the issue looks like before the fix:
screen shot 2018-05-12 at 2 56 26 pm

After fix it is without the blank topic box

Related PR: #3948

@techknowlogick techknowlogick added this to the 1.5.0 milestone May 12, 2018
@bkcsoft bkcsoft added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label May 12, 2018
@codecov-io
Copy link

codecov-io commented May 12, 2018

Codecov Report

Merging #3956 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3956      +/-   ##
==========================================
+ Coverage   20.26%   20.27%   +0.01%     
==========================================
  Files         146      146              
  Lines       29319    29319              
==========================================
+ Hits         5942     5945       +3     
+ Misses      22475    22473       -2     
+ Partials      902      901       -1
Impacted Files Coverage Δ
modules/process/manager.go 73.91% <0%> (+4.34%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c14870c...6910b83. Read the comment docs.

@lunny
Copy link
Member

lunny commented May 13, 2018

LGTM

@bkcsoft bkcsoft added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 13, 2018
@lunny lunny merged commit f6828e0 into go-gitea:master May 13, 2018
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants