Skip to content

fix not respecting landing page setting #4209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 15, 2018
Merged

fix not respecting landing page setting #4209

merged 3 commits into from
Jun 15, 2018

Conversation

daviian
Copy link
Member

@daviian daviian commented Jun 10, 2018 •
edited
Loading

Targets: #4079

TODO:

  • add tests

@daviian daviian force-pushed the bugfix/landing-page branch from ebb4caf to 06df2c9 Compare June 13, 2018 08:38
@codecov-io
Copy link

Codecov Report

Merging #4209 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4209   +/-   ##
=======================================
  Coverage   19.96%   19.96%           
=======================================
  Files         153      153           
  Lines       30521    30521           
=======================================
  Hits         6094     6094           
  Misses      23513    23513           
  Partials      914      914

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6efdcae...06df2c9. Read the comment docs.

@bkcsoft bkcsoft added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jun 13, 2018
@daviian
Copy link
Member Author

daviian commented Jun 13, 2018

@go-gitea/mergers Can you add it to milestone 1.5? The targeted issue is already in there.

@techknowlogick techknowlogick added this to the 1.5.0 milestone Jun 13, 2018
@techknowlogick
Copy link
Member

@daviian done

@bkcsoft bkcsoft added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jun 13, 2018
@bkcsoft bkcsoft added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 14, 2018
@lunny lunny merged commit adba2ad into go-gitea:master Jun 15, 2018
@daviian daviian deleted the bugfix/landing-page branch June 15, 2018 06:39
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@techknowlogick techknowlogick techknowlogick approved these changes

@sapk sapk sapk approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.5.0
Development

Successfully merging this pull request may close these issues.
6 participants
@daviian @codecov-io @techknowlogick @sapk @lunny @bkcsoft