Skip to content

Updated drone config to use the "next" git plugin #4281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 20, 2018

Conversation

kolaente
Copy link
Member

This pr tries to fix a drone behavior where drone wouldn't pick up the latest commit while saying it does so. This resulted in the build failing, even if everything was ok in the latest commit.

According to @tboerger, this is an issue with Github which wont get fixed, so I'm trying the next branch of the git plugin, so I'll try that with this pr. If it doesn't work, I'll close it.

@codecov-io
Copy link

codecov-io commented Jun 20, 2018

Codecov Report

Merging #4281 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4281      +/-   ##
==========================================
- Coverage   20.02%   20.01%   -0.01%     
==========================================
  Files         153      153              
  Lines       30584    30584              
==========================================
- Hits         6125     6122       -3     
- Misses      23533    23535       +2     
- Partials      926      927       +1
Impacted Files Coverage Δ
modules/avatar/avatar.go 81.25% <0%> (-18.75%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d84da8f...1146dd0. Read the comment docs.

@bkcsoft bkcsoft added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jun 20, 2018
@lafriks lafriks added the topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile label Jun 20, 2018
@bkcsoft bkcsoft added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jun 20, 2018
@bkcsoft bkcsoft added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 20, 2018
@lafriks lafriks merged commit cd29888 into go-gitea:master Jun 20, 2018
@lunny lunny added this to the 1.5.0 milestone Jun 21, 2018
@kolaente kolaente deleted the fix-drone branch July 15, 2018 18:30
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants