Skip to content

Add scope to Gitlab oauth request #4330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 30, 2018
Merged

Add scope to Gitlab oauth request #4330

merged 2 commits into from
Jun 30, 2018

Conversation

techknowlogick
Copy link
Member

Fix #3449

@techknowlogick techknowlogick added this to the 1.6.0 milestone Jun 27, 2018
@codecov-io
Copy link

codecov-io commented Jun 27, 2018 •
edited
Loading

Codecov Report

Merging #4330 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #4330   +/-   ##
======================================
  Coverage    20.1%   20.1%           
======================================
  Files         153     153           
  Lines       30705   30705           
======================================
  Hits         6174    6174           
  Misses      23588   23588           
  Partials      943     943

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e87c540...13263b0. Read the comment docs.

@bkcsoft bkcsoft added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jun 27, 2018
@bkcsoft bkcsoft added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jun 28, 2018
@bkcsoft bkcsoft added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 29, 2018
@lafriks lafriks modified the milestones: 1.6.0, 1.5.0 Jun 30, 2018
@lafriks lafriks merged commit 4ee52b7 into go-gitea:master Jun 30, 2018
@techknowlogick techknowlogick deleted the techknowlogick-patch-7 branch June 30, 2018 17:13
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sapk sapk sapk approved these changes

@jonasfranz jonasfranz jonasfranz approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.5.0
Development

Successfully merging this pull request may close these issues.

gitlab oauth is broken because scope is not sent
6 participants
@techknowlogick @codecov-io @sapk @jonasfranz @lafriks @bkcsoft