Skip to content

Fix SHA and compare regex on route file [Critical] #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 3, 2016
Merged

Fix SHA and compare regex on route file [Critical] #47

merged 3 commits into from
Nov 3, 2016

Conversation

thibaultmeyer
Copy link
Contributor

Related to the issue #3743, this pull request fix the regex used on the route file for SHA and branches comparisons.

  • A SHA hash can only contains a b c d e f 0 1 2 3 4 5 6 7 8 9
  • A branch name could be smaller than 7 characters

@DblK
Copy link
Member

DblK commented Nov 3, 2016

LGTM

@codecov-io
Copy link

codecov-io commented Nov 3, 2016

Current coverage is 2.18% (diff: 100%)

Merging #47 into master will not change coverage

@@            master       #47   diff @@
========================================
  Files           31        31          
  Lines         7508      7508          
  Methods          0         0          
  Messages         0         0          
  Branches         0         0          
========================================
  Hits           164       164          
  Misses        7327      7327          
  Partials        17        17          

Powered by Codecov. Last update 42a744d...1adde07

@lunny
Copy link
Member

lunny commented Nov 3, 2016

LGTM

@strk strk merged commit 137dcbf into go-gitea:master Nov 3, 2016
@tboerger tboerger added this to the 1.0.0 milestone Nov 3, 2016
@tboerger tboerger added the type/enhancement An improvement of existing functionality label Nov 3, 2016
@thibaultmeyer thibaultmeyer deleted the fix/3743-route-regexp-branchname branch November 3, 2016 22:05
@tboerger tboerger added the lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. label Nov 29, 2016
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/enhancement An improvement of existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants