Skip to content

ADD: Hint to function of docker version tags in tutorial #4967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 21, 2018
Merged

ADD: Hint to function of docker version tags in tutorial #4967

merged 2 commits into from
Sep 21, 2018

Conversation

Wyall
Copy link
Contributor

@Wyall Wyall commented Sep 20, 2018

I wasn't sure about how tags work, maybe this is interesting for people with less knowledge of docker.

But that's entirely up for discussion, basically what the target audience of the guide is.

I wasn't sure about how tags work, maybe this is interesting for people with less knowledge of docker.
@bkcsoft bkcsoft added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Sep 20, 2018
@lafriks lafriks added the type/docs This PR mainly updates/creates documentation label Sep 20, 2018
@bkcsoft bkcsoft added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Sep 20, 2018
@codecov-io
Copy link

codecov-io commented Sep 20, 2018

Codecov Report

Merging #4967 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4967      +/-   ##
==========================================
+ Coverage    37.4%   37.41%   +<.01%     
==========================================
  Files         306      306              
  Lines       45334    45334              
==========================================
+ Hits        16957    16960       +3     
+ Misses      25925    25923       -2     
+ Partials     2452     2451       -1
Impacted Files Coverage Δ
models/repo_indexer.go 52.11% <0%> (+1.27%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 07af31d...a9a4a5d. Read the comment docs.

@lunny lunny merged commit dab02b8 into go-gitea:master Sep 21, 2018
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/docs This PR mainly updates/creates documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants