Skip to content

Fix preview when adding new code review comment #4975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 25, 2018

Conversation

lafriks
Copy link
Member

@lafriks lafriks commented Sep 24, 2018

Fixes #4947

@lafriks lafriks added this to the 1.6.0 milestone Sep 24, 2018
@codecov-io
Copy link

Codecov Report

Merging #4975 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #4975      +/-   ##
=========================================
- Coverage    37.4%   37.4%   -0.01%     
=========================================
  Files         306     306              
  Lines       45343   45343              
=========================================
- Hits        16962   16960       -2     
- Misses      25930   25932       +2     
  Partials     2451    2451
Impacted Files Coverage Δ
models/repo_list.go 61.76% <0%> (-1.18%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 36e7cb9...1c2b0b7. Read the comment docs.

@bkcsoft bkcsoft added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Sep 24, 2018
@bkcsoft bkcsoft added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Sep 25, 2018
@bkcsoft bkcsoft added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Sep 25, 2018
@jonasfranz jonasfranz added the topic/ui Change the appearance of the Gitea UI label Sep 25, 2018
@jonasfranz jonasfranz merged commit 4092b32 into go-gitea:master Sep 25, 2018
@lafriks lafriks deleted the fix/review_preview branch September 25, 2018 12:39
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't view "Preview" on comments on pull requests
5 participants