Skip to content

add myself to maintainers #5098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 17, 2018
Merged

add myself to maintainers #5098

merged 1 commit into from
Oct 17, 2018

Conversation

kolaente
Copy link
Member

@kolaente kolaente commented Oct 17, 2018 •
edited
Loading

🙂

@bkcsoft bkcsoft added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Oct 17, 2018
@codecov-io
Copy link

Codecov Report

Merging #5098 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5098      +/-   ##
==========================================
+ Coverage    37.4%   37.41%   +0.01%     
==========================================
  Files         306      306              
  Lines       45374    45374              
==========================================
+ Hits        16973    16978       +5     
+ Misses      25947    25944       -3     
+ Partials     2454     2452       -2
Impacted Files Coverage Δ
models/repo_list.go 62.94% <0%> (+1.17%) ⬆️
models/repo_indexer.go 52.11% <0%> (+1.27%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1972383...403aa73. Read the comment docs.

@bkcsoft bkcsoft added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 17, 2018
@techknowlogick techknowlogick merged commit 35ae140 into go-gitea:master Oct 17, 2018
@techknowlogick
Copy link
Member

🎉🎉🎉

@kolaente kolaente deleted the add-myself-to-maintainer branch October 18, 2018 08:01
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jonasfranz jonasfranz jonasfranz approved these changes

@adelowo adelowo adelowo approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@kolaente @codecov-io @techknowlogick @jonasfranz @adelowo @bkcsoft