Skip to content

Rephrase password reset button labels #5240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Rephrase password reset button labels #5240

wants to merge 1 commit into from

Conversation

jamesa
Copy link
Contributor

@jamesa jamesa commented Oct 31, 2018

Fixes #5039

I didn't change all of the "Click Here" phrasing, some of it seemed ok to me. Hope this helps.

@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@c8b4c7a). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #5240   +/-   ##
=========================================
  Coverage          ?   37.48%           
=========================================
  Files             ?      310           
  Lines             ?    45923           
  Branches          ?        0           
=========================================
  Hits              ?    17213           
  Misses            ?    26236           
  Partials          ?     2474

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c8b4c7a...d6f1f30. Read the comment docs.

@bkcsoft bkcsoft added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Oct 31, 2018
@techknowlogick
Copy link
Member

Thanks for PR @jamesa. @coolaj86's PR #5042 has these changes currently.

@jamesa
Copy link
Contributor Author

jamesa commented Nov 1, 2018

Ah, my mistake. Thanks!

@jamesa jamesa deleted the update-password-text branch November 1, 2018 03:18
@techknowlogick
Copy link
Member

@jamesa totally fine. It's not reasonable to expect everyone to go through all 100+ PRs to see what's already there. We do appreciate the the contribution.

@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

en: many buttons labeled "click here"
4 participants