Skip to content

branch: Trigger update when deleting branch via UI. #5617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 2, 2019

Conversation

HarshitOnGitHub
Copy link
Contributor

I also tried the approach to delete the branch by executing git push --delete origin <banch_name> in local copy of repository but it didn't trigger the post-receive hook. I tried debugging and everything seems fine yet a push via local copy doesn't trigger update. Can anyone shed some light on this?

Fixes: #5309.

@codecov-io
Copy link

codecov-io commented Jan 2, 2019

Codecov Report

Merging #5617 into master will decrease coverage by 0.01%.
The diff coverage is 72.72%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #5617      +/-   ##
=========================================
- Coverage   37.82%   37.8%   -0.02%     
=========================================
  Files         322     322              
  Lines       47463   47474      +11     
=========================================
- Hits        17952   17949       -3     
- Misses      26928   26937       +9     
- Partials     2583    2588       +5
Impacted Files Coverage Δ
routers/repo/branch.go 58.19% <72.72%> (+0.96%) ⬆️
models/repo_indexer.go 44.49% <0%> (-3.82%) ⬇️
models/repo_list.go 63.29% <0%> (-1.27%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c52858...8e12a4b. Read the comment docs.

@bkcsoft bkcsoft added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 2, 2019
@lafriks lafriks added this to the 1.7.0 milestone Jan 2, 2019
@lafriks
Copy link
Member

lafriks commented Jan 2, 2019

Temp checkout&push would be needed to trigger hooks but I don't think it is reasonable performance wise

@bkcsoft bkcsoft added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 2, 2019
@HarshitOnGitHub
Copy link
Contributor Author

Temp checkout&push would be needed to trigger hooks

I did the same but still it didn't trigger the hooks. I have the code if you would like to have a look.

I don't think it is reasonable performance wise

Yeah that is why went ahead with this approach. :)

@bkcsoft bkcsoft added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 2, 2019
@lunny lunny merged commit 8764f15 into go-gitea:master Jan 2, 2019
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deleting branch does not trigger update's hook via the UI
6 participants