Skip to content

fix migration for user defined themes #5682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 12, 2019
Merged

Conversation

adelowo
Copy link
Member

@adelowo adelowo commented Jan 9, 2019

Fixes #5681

Friendly ping @wyattoday @kimpenhaus

@adelowo adelowo changed the title fix migration fix migration for user defined themes Jan 9, 2019
@codecov-io
Copy link

codecov-io commented Jan 9, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@2b36bdd). Click here to learn what that means.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #5682   +/-   ##
=========================================
  Coverage          ?   37.75%           
=========================================
  Files             ?      323           
  Lines             ?    47596           
  Branches          ?        0           
=========================================
  Hits              ?    17972           
  Misses            ?    27034           
  Partials          ?     2590
Impacted Files Coverage Δ
models/migrations/v77.go 0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b36bdd...9f3cda2. Read the comment docs.

@bkcsoft bkcsoft added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 9, 2019
@techknowlogick techknowlogick added this to the 1.8.0 milestone Jan 10, 2019
@bkcsoft bkcsoft added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 10, 2019
@allenh1
Copy link

allenh1 commented Jan 11, 2019

Is there a way I can work around this temporarily (while this is getting merged)?

@kimpenhaus
Copy link

You can try and make an update to the SQL table user and set theme to empty string (or gitea or arc-green).

@bkcsoft bkcsoft added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gitea fails to start: Failed to initialize ORM engine: sync database struct error: Error 1265: Data truncated for column 'theme' at row 1
8 participants