UI: Make navbar full width #5998
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5998 +/- ##
=======================================
Coverage 38.76% 38.76%
=======================================
Files 332 332
Lines 48938 48938
=======================================
Hits 18969 18969
Misses 27222 27222
Partials 2747 2747Continue to review full report at Codecov.
|
GiteaBot
added
the
lgtm/need 2
kolaente
approved these changes
Feb 7, 2019
GiteaBot
added
lgtm/need 1
adelowo
approved these changes
Feb 7, 2019
GiteaBot
added
lgtm/done
sapk
approved these changes
Feb 7, 2019
|
@zeripath please do not merge without adding needed labels and milestone |
|
@silverwind but the username on the secondary menu should also be align with the top menu. |
|
It is aligned with the container below not visible in the screenshot. Will think about something for this user menu, not happy with it. |
kolaente
added a commit
to kolaente/gitea
that referenced
this pull request
Feb 8, 2019
This reverts commit 4c5b585.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the main navbar full-width, matching GitHub's design. I also tested and ensured this change does not affect the mobile layout.
Before
After