Skip to content

Allow display of LFS stored Readme.md on directory page (#6073) #6099

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Feb 21, 2019
Merged

Allow display of LFS stored Readme.md on directory page (#6073) #6099

merged 11 commits into from
Feb 21, 2019

Conversation

zeripath
Copy link
Contributor

@zeripath zeripath commented Feb 16, 2019 •
edited
Loading

Allows display of Git LFS stored Readme.md files.

Also fixes bug with display of text files stored with LFS which are >1Kb.

Fix #6073

@codecov-io
Copy link

codecov-io commented Feb 16, 2019 •
edited
Loading

Codecov Report

Merging #6099 into master will decrease coverage by 0.03%.
The diff coverage is 16.04%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6099      +/-   ##
==========================================
- Coverage   38.86%   38.82%   -0.04%     
==========================================
  Files         354      354              
  Lines       50115    50171      +56     
==========================================
+ Hits        19475    19481       +6     
- Misses      27822    27869      +47     
- Partials     2818     2821       +3
Impacted Files Coverage Δ
routers/repo/view.go 42.07% <16.04%> (-3.62%) ⬇️
modules/avatar/avatar.go 81.25% <0%> (-18.75%) ⬇️
models/unit.go 0% <0%> (-14.29%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 994b1be...6fc05df. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 16, 2019
@zeripath zeripath added type/bug topic/ui Change the appearance of the Gitea UI labels Feb 17, 2019
lafriks
lafriks reviewed Feb 18, 2019
View reviewed changes
lafriks
lafriks reviewed Feb 18, 2019
View reviewed changes
@zeripath
Slight restructure
7e4a3c2 
Signed-off-by: Andrew Thornton <[email protected]>
@zeripath
Slight restructure
f7ca6de 
Signed-off-by: Andrew Thornton <[email protected]>
lafriks
lafriks reviewed Feb 18, 2019
View reviewed changes
lafriks
lafriks reviewed Feb 18, 2019
View reviewed changes
@lafriks lafriks added this to the 1.8.0 milestone Feb 19, 2019
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 20, 2019
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 21, 2019
@techknowlogick
Copy link
Member

Make lg-tm work

@techknowlogick techknowlogick merged commit 3b61ff1 into go-gitea:master Feb 21, 2019
@zeripath zeripath deleted the issue-6073-readme.md-lfs branch April 22, 2019 20:22
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lafriks lafriks lafriks approved these changes

@jolheiser jolheiser jolheiser approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI type/bug
Projects
None yet
Milestone
1.8.0
Development

Successfully merging this pull request may close these issues.

README.md not working with Git LFS
7 participants
@zeripath @codecov-io @techknowlogick @lafriks @jolheiser @GiteaBot @lunny