Skip to content

feat(docker): speed up docker build. #6159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 23, 2019
Merged

feat(docker): speed up docker build. #6159

merged 4 commits into from
Feb 23, 2019

Conversation

appleboy
Copy link
Member

@appleboy appleboy commented Feb 22, 2019

As title. See the ref: https://semaphoreci.com/docs/docker/docker-layer-caching.html

before

Build time: 02:14 Link

after

Build time: 01:31 Link

go-gitea_gitea___drone

@lafriks lafriks added the pr/wip This PR is not ready for review label Feb 22, 2019
@codecov-io
Copy link

codecov-io commented Feb 22, 2019

Codecov Report

Merging #6159 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6159      +/-   ##
==========================================
- Coverage   38.85%   38.84%   -0.01%     
==========================================
  Files         354      354              
  Lines       50183    50183              
==========================================
- Hits        19497    19496       -1     
  Misses      27861    27861              
- Partials     2825     2826       +1
Impacted Files Coverage Δ
modules/avatar/avatar.go 81.25% <0%> (-18.75%) ⬇️
models/repo_list.go 67.89% <0%> (+1.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a2fbbe...b35ee16. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 22, 2019
@appleboy appleboy removed the pr/wip This PR is not ready for review label Feb 22, 2019
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 22, 2019
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 22, 2019
@lunny lunny merged commit 035c82a into go-gitea:master Feb 23, 2019
@appleboy appleboy deleted the docker branch February 23, 2019 01:24
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/deployment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants