Skip to content

refactor: check the error returned by os.MkdirAll() #625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 10, 2017
Merged

refactor: check the error returned by os.MkdirAll() #625

merged 1 commit into from
Jan 10, 2017

Conversation

appleboy
Copy link
Member

@appleboy appleboy commented Jan 9, 2017

As title.

@lunny
Copy link
Member

lunny commented Jan 9, 2017

If the dir is exist, it will return nil or an error that dir is exist?

@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 9, 2017
@appleboy
Copy link
Member Author

appleboy commented Jan 9, 2017

It will return nil if the folder is exist.

@lunny
Copy link
Member

lunny commented Jan 9, 2017

https://godoc.org/os#MkdirAll seems that you don't need to change anything.

@lunny
Copy link
Member

lunny commented Jan 9, 2017

LGTM

@tboerger tboerger added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 9, 2017
@lunny lunny added this to the 1.1.0 milestone Jan 9, 2017
@lunny lunny added the type/enhancement An improvement of existing functionality label Jan 9, 2017
@ethantkoenig
Copy link
Member

LGTM

1 similar comment
@metalmatze
Copy link
Contributor

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 10, 2017
@metalmatze metalmatze merged commit ecfa284 into go-gitea:master Jan 10, 2017
@appleboy appleboy deleted the improve branch January 10, 2017 15:38
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.
5 participants
@appleboy @lunny @ethantkoenig @metalmatze @tboerger