-
-
Notifications
You must be signed in to change notification settings - Fork 5.9k
docs: document setup with read-only config #6348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #6348 +/- ##
==========================================
+ Coverage 38.86% 38.86% +<.01%
==========================================
Files 365 365
Lines 51389 51389
==========================================
+ Hits 19970 19972 +2
+ Misses 28551 28549 -2
Partials 2868 2868
Continue to review full report at Codecov.
|
@nodiscc translation of docs is done directly by updating the file. The french doc is far outdated and a refresh could really be great. Don't hesitate to ping me in your PR if you do so I would gladly review it. |
@jolheiser @axifive Thank you, fixed following your review. @sapk I will work on it, sure. Wouldn't it make sense for the docs to use a localization system like Untranslated/out-of-date paragraphs would simply be displayed in english. A minimalist alternative is a small banner on all localized pages |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For consistency, should use Hugo relref
function.
CI is failing. |
@jolheiser updated. |
Seems build is failing from untouched pages. I wonder if version of hugo in image we use has been updated. |
@techknowlogick I run the test on master and seems fine as the PR branch failed. It maybe related to the relative path. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With those changes it should work.
@@ -82,6 +82,7 @@ chmod 770 /etc/gitea | |||
chmod 750 /etc/gitea | |||
chmod 644 /etc/gitea/app.ini | |||
``` | |||
If you don't want the web installer to be able to write the config file at all, it is also possible to make the config file read-only for the gitea user (owner/group `root:root`, mode `0660`), and set `INSTALL_LOCK = true`. In that case all database configuration details must be set beforehand in the config file, as well as the `SECRET_KEY` and `INTERNAL_TOKEN` values. See the [command line documentation]({{< relref "doc/usage/command-line.md" >}}) for information on using `gitea generate secret INTERNAL_TOKEN`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems that for relref you need to include the language. So this should be like this.
If you don't want the web installer to be able to write the config file at all, it is also possible to make the config file read-only for the gitea user (owner/group `root:root`, mode `0660`), and set `INSTALL_LOCK = true`. In that case all database configuration details must be set beforehand in the config file, as well as the `SECRET_KEY` and `INTERNAL_TOKEN` values. See the [command line documentation]({{< relref "doc/usage/command-line.md" >}}) for information on using `gitea generate secret INTERNAL_TOKEN`. | |
If you don't want the web installer to be able to write the config file at all, it is also possible to make the config file read-only for the gitea user (owner/group `root:root`, mode `0660`), and set `INSTALL_LOCK = true`. In that case all database configuration details must be set beforehand in the config file, as well as the `SECRET_KEY` and `INTERNAL_TOKEN` values. See the [command line documentation]({{< relref "doc/usage/command-line.en-us.md" >}}) for information on using `gitea generate secret INTERNAL_TOKEN`. |
And rename the file doc/usage/command-line.md
to doc/usage/command-line.en-us.md
Ref. #5704
I don't know what the process to update doc translations is. I could update the french docs if needed.