chore: update drone format to 1.0 #6602

appleboy · 2019-04-13T13:18:14Z

remove git clone steps and execute the following command to change the format:

$ drone convert --save

fix #6463

codecov-io · 2019-04-13T13:42:20Z

Codecov Report

❗ No coverage uploaded for pull request base (master@0dca17b). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #6602   +/-   ##
=========================================
  Coverage          ?   41.23%           
=========================================
  Files             ?      466           
  Lines             ?    63153           
  Branches          ?        0           
=========================================
  Hits              ?    26044           
  Misses            ?    33705           
  Partials          ?     3404

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0dca17b...36ae8b7. Read the comment docs.

tboerger · 2019-04-15T22:35:16Z

.drone.yml

+    ignore_branch: true
+    project_identifier: gitea
+  environment:
+    CROWDIN_KEY:


You should convert this kind of environment variables into settings.

tboerger · 2019-04-15T22:35:52Z

.drone.yml

+  - npm install
+  - make stylesheets-check
+  when:
+    event:


Maybe just drop the events entirely?

tboerger · 2019-04-15T22:36:29Z

.drone.yml

-    pull: true
+  environment:
+    TAGS: bindata sqlite sqlite_unlock_notify
+  when:


These conditions won't work anymore as far as I know. You should use ref

techknowlogick · 2019-04-16T16:24:20Z

.drone.yml

-    project_identifier: gitea
-    ignore_branch: true
+steps:
+- name: download_translations


Could you split out translation steps into a different pipeline?

kolaente · 2019-05-02T21:33:24Z

@appleboy How's the status here?

appleboy · 2019-05-03T01:35:09Z

@kolaente I will update asap

kolaente · 2019-06-06T13:44:51Z

@appleboy anything we can help you with?

kolaente · 2019-06-30T13:30:37Z

@appleboy If it's ok for you, I'm going to take over this pr since we need it.

Signed-off-by: konrad <[email protected]>

appleboy · 2019-06-30T15:06:33Z

@kolaente OK, Thank you.

Signed-off-by: konrad <[email protected]>

appleboy · 2019-06-30T15:11:03Z

@kolaente maybe you can update this PR not create new PR.

Signed-off-by: konrad <[email protected]>

kolaente · 2019-06-30T16:14:54Z

Things I've changed:

I've refactored the drone file to use the new syntax of drone 1, which brings several advanteges:

multiple pipelines
dependencies of steps -> paralle execution of tests

Multiple pipelines:

testing: Runs all linters, unit and integration tests
translations: Downloads the newest translations from crowdin and also pushes them back to the repo
release: cross-compiles releases with xgo and publishes them
docs: publishes the docs
docker: builds and publishes the docker images
notify: triggers the discord notify hook

From the parallelization the whole pipeline now takes ~15min instead of 35min for a pr! 🎉

.drone.yml

Signed-off-by: konrad <[email protected]>

kolaente · 2019-06-30T17:00:05Z

@tboerger @lunny @lafriks @appleboy please review.

.drone.yml

Signed-off-by: konrad <[email protected]>

appleboy · 2019-06-30T17:26:04Z

@kolaente LGTM

* chore: update drone format to 1.0 * Converted old drone config Signed-off-by: konrad <[email protected]> * Moved translations to seperate pipeline Signed-off-by: konrad <[email protected]> * Split the steps in multiple pipelines and add dependencies Signed-off-by: konrad <[email protected]> * format Signed-off-by: konrad <[email protected]> * Fixed step depenednecies Signed-off-by: konrad <[email protected]> * Fixed discord notify Signed-off-by: konrad <[email protected]> * Exclude translations and docs pipelines from prs Signed-off-by: konrad <[email protected]> * Fixed exclude prs Signed-off-by: konrad <[email protected]> * Fixed exclude prs Signed-off-by: konrad <[email protected]> * Moved releases to seperate pipeline Signed-off-by: konrad <[email protected]> * Re-trigger drone Signed-off-by: konrad <[email protected]> * Disable release step Signed-off-by: konrad <[email protected]> * Fixed depending step Signed-off-by: konrad <[email protected]> * Adopted dependencies Signed-off-by: konrad <[email protected]> * Changed pipeline conditions Signed-off-by: konrad <[email protected]> * Replaced pipeline conditions with triggers Signed-off-by: konrad <[email protected]> * Fixed coverage step Signed-off-by: konrad <[email protected]> * Import changes from go-gitea#7331 Signed-off-by: konrad <[email protected]> * Add comment for lowest go version Signed-off-by: konrad <[email protected]> * Exclude fetch-tags from prs Signed-off-by: konrad <[email protected]> * Re-added comment about no tags Signed-off-by: konrad <[email protected]> * Removed unneeded conditions Signed-off-by: konrad <[email protected]> * Moved release version and release latest to different pipelines Signed-off-by: konrad <[email protected]> * Fixed depending pipeline Signed-off-by: konrad <[email protected]> * Removed the conditions for all services Signed-off-by: konrad <[email protected]>

chore: update drone format to 1.0

67d404f

appleboy requested review from lunny, tboerger, techknowlogick and lafriks April 13, 2019 13:18

lunny added the topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile label Apr 13, 2019

GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 13, 2019

tboerger reviewed Apr 15, 2019

View reviewed changes

techknowlogick reviewed Apr 16, 2019

View reviewed changes

kolaente added 3 commits June 30, 2019 15:33

Converted old drone config

b94724d

Signed-off-by: konrad <[email protected]>

Moved translations to seperate pipeline

a1a3a4a

Signed-off-by: konrad <[email protected]>

Split the steps in multiple pipelines and add dependencies

07534fe

Signed-off-by: konrad <[email protected]>

kolaente mentioned this pull request Jun 30, 2019

Update drone to use drone 1 format #7331

Closed

kolaente added 6 commits June 30, 2019 16:21

format

8a113ca

Signed-off-by: konrad <[email protected]>

Fixed step depenednecies

c7f1b99

Signed-off-by: konrad <[email protected]>

Fixed discord notify

638dab0

Signed-off-by: konrad <[email protected]>

Exclude translations and docs pipelines from prs

16d02f1

Signed-off-by: konrad <[email protected]>

Fixed exclude prs

36bc95f

Signed-off-by: konrad <[email protected]>

Fixed exclude prs

079f9b1

Signed-off-by: konrad <[email protected]>

Moved releases to seperate pipeline

fb99cbb

Signed-off-by: konrad <[email protected]>

kolaente added 3 commits June 30, 2019 17:11

Re-trigger drone

9006d68

Signed-off-by: konrad <[email protected]>

Disable release step

7838087

Signed-off-by: konrad <[email protected]>

Fixed depending step

a99c741

Signed-off-by: konrad <[email protected]>

Import changes from go-gitea#7331

19d5399

Signed-off-by: konrad <[email protected]>

kolaente force-pushed the drone branch from 19d5399 to d7839be Compare June 30, 2019 16:11

Merge remote-tracking branch 'appleboy/drone' into appleboy-drone

0cdf631

techknowlogick reviewed Jun 30, 2019

View reviewed changes

.drone.yml Show resolved Hide resolved

techknowlogick reviewed Jun 30, 2019

View reviewed changes

.drone.yml Show resolved Hide resolved

kolaente added 6 commits June 30, 2019 18:20

Add comment for lowest go version

c6058f7

Signed-off-by: konrad <[email protected]>

Exclude fetch-tags from prs

166a31b

Signed-off-by: konrad <[email protected]>

Re-added comment about no tags

433a64c

Signed-off-by: konrad <[email protected]>

Removed unneeded conditions

28e42b9

Signed-off-by: konrad <[email protected]>

Moved release version and release latest to different pipelines

488b6f5

Signed-off-by: konrad <[email protected]>

Fixed depending pipeline

05aaa98

Signed-off-by: konrad <[email protected]>

techknowlogick approved these changes Jun 30, 2019

View reviewed changes

GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jun 30, 2019

appleboy commented Jun 30, 2019

View reviewed changes

.drone.yml Show resolved Hide resolved

Removed the conditions for all services

ca7417b

Signed-off-by: konrad <[email protected]>

zeripath requested a review from tboerger June 30, 2019 17:43

Merge branch 'master' into drone

36ae8b7

lafriks approved these changes Jun 30, 2019

View reviewed changes

GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 30, 2019

techknowlogick merged commit e5a4d78 into go-gitea:master Jun 30, 2019

techknowlogick added this to the 1.9.0 milestone Jun 30, 2019

stertingen mentioned this pull request Jul 3, 2019

New drone file format broke CONTRIBUTING.md #7350

Closed

go-gitea locked and limited conversation to collaborators Nov 24, 2020

Uh oh!

chore: update drone format to 1.0 #6602

chore: update drone format to 1.0 #6602

Uh oh!

Conversation

appleboy commented Apr 13, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov-io commented Apr 13, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

tboerger Apr 15, 2019

Choose a reason for hiding this comment

Uh oh!

tboerger Apr 15, 2019

Choose a reason for hiding this comment

Uh oh!

tboerger Apr 15, 2019

Choose a reason for hiding this comment

Uh oh!

techknowlogick Apr 16, 2019

Choose a reason for hiding this comment

Uh oh!

kolaente commented May 2, 2019

Uh oh!

appleboy commented May 3, 2019

Uh oh!

kolaente commented Jun 6, 2019

Uh oh!

kolaente commented Jun 30, 2019

Uh oh!

appleboy commented Jun 30, 2019

Uh oh!

appleboy commented Jun 30, 2019

Uh oh!

kolaente commented Jun 30, 2019

Things I've changed:

Uh oh!

Uh oh!

Uh oh!

kolaente commented Jun 30, 2019

Uh oh!

Uh oh!

appleboy commented Jun 30, 2019

Uh oh!

Uh oh!

appleboy commented Apr 13, 2019 •

edited

Loading

codecov-io commented Apr 13, 2019 •

edited

Loading