Skip to content

[backport] Fix forking an empty repository (#6637) #6653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 16, 2019

Conversation

segevfiner
Copy link
Contributor

Backport to v1.8

Forking an empty repo didn't copy the IsEmpty flag which lead to Git errors, and once we did copy it, the repoAssignment middleware didn't populate BaseRepo which lead to a nil error from the templates.

Fixes #6633 (Assuming there aren't issues in other places)

cc @lunny

@techknowlogick techknowlogick added modifies/api This PR adds API routes or modifies them type/bug labels Apr 16, 2019
@techknowlogick techknowlogick added this to the 1.8.0 milestone Apr 16, 2019
@techknowlogick techknowlogick removed the modifies/api This PR adds API routes or modifies them label Apr 16, 2019
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Apr 16, 2019
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 16, 2019
@zeripath
Copy link
Contributor

make Lg-tm work

@zeripath zeripath merged commit 5236d8a into go-gitea:release/v1.8 Apr 16, 2019
@segevfiner segevfiner deleted the fork-empty-bug-1.8 branch April 16, 2019 19:47
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
project-mirrors-bot-tu bot pushed a commit to project-mirrors/forgejo-as-gitea-fork that referenced this pull request Jan 31, 2025
…a#6734)

- No longer autofocus on the searchbox for the repository list that is on the dashboard. There is no justification for doing so.
- Fixes go-gitea#6653

Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/6734
Reviewed-by: Otto <[email protected]>
Reviewed-by: Beowulf <[email protected]>
Reviewed-by: Gusted <[email protected]>
Co-authored-by: Natalie Klestrup Röijezon <[email protected]>
Co-committed-by: Natalie Klestrup Röijezon <[email protected]>
project-mirrors-bot-tu bot pushed a commit to project-mirrors/forgejo-as-gitea-fork that referenced this pull request Jan 31, 2025
…rch box (go-gitea#6748)

- No longer autofocus on the searchbox for the repository list that is on the dashboard. There is no justification for doing so.
- Fixes go-gitea#6653
Co-authored-by: forgejo-backport-action <[email protected]>
Co-committed-by: forgejo-backport-action <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants