Skip to content

refactor: move js to bottom and move css to top. #689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 25, 2017
Merged

refactor: move js to bottom and move css to top. #689

merged 1 commit into from
Jan 25, 2017

Conversation

appleboy
Copy link
Member

  • move CSS link to <head> section.
  • move js link to bottom of <body> section.

tboerger
tboerger reviewed Jan 18, 2017
View reviewed changes
templates/base/footer.tmpl
{{end}}

<!-- Stylesheet -->
<link rel="stylesheet" href="{{AppSubUrl}}/css/index.css?v={{MD5 AppVer}}">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be in the head

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

templates/base/footer.tmpl
@@ -27,26 +27,43 @@
</div>
</div>
</footer>
</body>
<script src="{{AppSubUrl}}/js/jquery-1.11.3.min.js"></script>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be indented by one level

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

templates/base/head.tmpl
<title>{{if .Title}}{{.Title}} - {{end}}{{AppName}}</title>

<meta name="theme-color" content="{{ThemeColorMetaTag}}">
{{if .RequireHighlightJS}}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should also be indented by one level

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I refactor head file.

@lunny lunny added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Jan 18, 2017
@lunny lunny added this to the 1.1.0 milestone Jan 18, 2017
@appleboy appleboy force-pushed the template branch 2 times, most recently from d547dd3 to 196812c Compare January 18, 2017 07:08
@lunny
Copy link
Member

lunny commented Jan 18, 2017

build failed.

@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 18, 2017
@appleboy
Copy link
Member Author

screen shot 2017-01-18 at 4 33 10 pm

github api error?

@appleboy
Copy link
Member Author

@lunny build successfully.

@lunny
Copy link
Member

lunny commented Jan 19, 2017

LGTM

@tboerger tboerger added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 19, 2017
@andreynering
Copy link
Contributor

Trusted LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 25, 2017
@lunny lunny merged commit 2831267 into go-gitea:master Jan 25, 2017
@appleboy appleboy deleted the template branch January 25, 2017 15:18
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tboerger tboerger tboerger left review comments

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.
4 participants
@appleboy @lunny @andreynering @tboerger