Refactoring of the makefile #69
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metalmatze
reviewed
Nov 4, 2016
|
|
||
| fixme: | ||
| grep -rnw "FIXME" routers models modules | ||
| .IGNORE: public/js/gogs.js |
There was a problem hiding this comment.
This is gogs.js for now, until someone updates the frontend? Right?
|
Really solid |
|
LGTM |
Current coverage is 2.18% (diff: 0.00%)@@ master #69 diff @@
========================================
Files 31 31
Lines 7508 7508
Methods 0 0
Messages 0 0
Branches 0 0
========================================
Hits 164 164
Misses 7327 7327
Partials 17 17
|
|
Wow !!!!!!! simply awesome @tboerger |
|
LGTM |
|
Rebased on latest master |
|
LGTM |
bkcsoft
reviewed
Nov 4, 2016
| *.db | ||
| *.log | ||
| log/ |
There was a problem hiding this comment.
Why skip this? (though it should be /log if anything ^.^)
|
I will create a followup PR for templates and public bindata and than also for Drone. |
…or)", replaced with custom name
tboerger
changed the title
tboerger
added
the
lgtm/done
lunny
pushed a commit
to lunny/gitea
that referenced
this pull request
Feb 7, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have refactored the makefile like I'm already using for other projects. It's prepared for cross-compiling Gitea for various platforms, you can see a list of the resulting binaries below. So what's next? Next steps will be the integration of
publicandtemplatesinto the binary and enabling Drone CI instead of Travis to directly provide publishing functionalities.I have alredy opened this pull request to gather early feedback on my proposed changes.