Skip to content

Clean Lato font #6920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Clean Lato font #6920

wants to merge 1 commit into from

Conversation

xf-
Copy link
Contributor

@xf- xf- commented May 12, 2019

eot is for <= IE8 and #iefix is around <= 6. TTF is not supported by many browsers and not included in vendor folder in gitea.

Woff is support IE >= 9 and every other major browser supported in your autoprefixer rule. Woff2 has better compression and is support by many browsers:
https://caniuse.com/#search=woff

font display is relative new and describes the behavior font is replaced after loading it.

@techknowlogick techknowlogick added the topic/ui Change the appearance of the Gitea UI label May 12, 2019
@techknowlogick techknowlogick added this to the 1.9.0 milestone May 12, 2019
@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@3d82367). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #6920   +/-   ##
=========================================
  Coverage          ?   41.41%           
=========================================
  Files             ?      440           
  Lines             ?    59738           
  Branches          ?        0           
=========================================
  Hits              ?    24743           
  Misses            ?    31759           
  Partials          ?     3236

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d82367...da3d96e. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 12, 2019
@silverwind
Copy link
Member

Looking good, but we should verify that our webserver serves the correct mime type for .woff2 (font/woff2) and .woff (font/woff) files.

@xf-
Copy link
Contributor Author

xf- commented May 13, 2019

@silverwind eot works only in old IE foo and ttf isn't shipped. Should work already or Fallback to a system font.
I would replace the lato font with noto anyway. Noto contains fonts for nearly every language and also Monospaced font. I wanted to open an issue someday about this.

@xf- xf- force-pushed the task/fontChaos branch from da3d96e to 5f3fbdd Compare May 13, 2019 19:42
@xf-
Copy link
Contributor Author

xf- commented May 13, 2019

I will open a new one with Noto and sematic already loads the font - duplicate

@xf- xf- closed this May 13, 2019
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. topic/ui Change the appearance of the Gitea UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants