Skip to content

Added Note about arm7 version to doc #6983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 23, 2019
Merged

Added Note about arm7 version to doc #6983

merged 6 commits into from
May 23, 2019

Conversation

suisseWalter
Copy link
Contributor

This pull request adds a troubleshooting subsection for the non working arm7 release on raspberry Pi's in the installation part of the documentation.
This pull request was suggested in issue #6979

Appended the Troubleshooting section with a subsection about the broken arm7 version and the recommendation to switch to arm6.
split the Gitea not running on Raspbian into two lines (reason, conclusion)
@techknowlogick techknowlogick added the type/docs This PR mainly updates/creates documentation label May 18, 2019
@mrsdizzie
Copy link
Member

mrsdizzie commented May 18, 2019

This feels wrong -- I still think we should just remove the arm7 version from the downloads section if it is known to not work for a while (and reported regularly). It doesn't make sense to offer something known to not work with a note that says "this does not work" buried in one of the docs.

Not fault of PR as it was suggested, but I think a better solution is to not give people a chance to download the file at all if we know it is broken, 100% avoiding the problem until it can be fixed.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 18, 2019
@suisseWalter
Copy link
Contributor Author

yes, I do agree with that but I don't have any idea on how to change that. therefore I did this. so if someone just removes arm7 I would be really happy. also is arm7 completely broken or only on raspbian?

@codecov-io
Copy link

codecov-io commented May 18, 2019

Codecov Report

Merging #6983 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6983      +/-   ##
==========================================
- Coverage   41.49%   41.49%   -0.01%     
==========================================
  Files         440      440              
  Lines       59457    59457              
==========================================
- Hits        24672    24671       -1     
- Misses      31566    31567       +1     
  Partials     3219     3219
Impacted Files Coverage Δ
routers/repo/view.go 42.02% <0%> (-1.02%) ⬇️
models/repo_list.go 73.09% <0%> (+1.01%) ⬆️
modules/log/colors_router.go 87.5% <0%> (+4.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 54bd63c...d9c482b. Read the comment docs.

@lunny
Copy link
Member

lunny commented May 19, 2019

I like @mrsdizzie 's idea. We can manually delete exist arm-7 binaries and change the Makefile to avoid to compile arm7 binary.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 20, 2019
@lafriks
Copy link
Member

lafriks commented May 20, 2019

imho it is good to have info in docs while we have not fixed the issue

@zeripath
Copy link
Contributor

@suisseWalter if you accept my suggested changes I'll approve. Even if we stop building the broken arm 7 builds we'll need to say something and this would do.

suisseWalter and others added 2 commits May 23, 2019 15:53
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 23, 2019
@zeripath
Copy link
Contributor

make LG-TM work

@zeripath zeripath merged commit 181b7c9 into go-gitea:master May 23, 2019
jeffliu27 pushed a commit to jeffliu27/gitea that referenced this pull request Jul 18, 2019
Appended the Troubleshooting section with a subsection about the problems with the arm7 version and the recommendation to switch to arm6.
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/docs This PR mainly updates/creates documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants