Skip to content

Spun attachments into seperate go file #701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 20, 2017
Merged

Spun attachments into seperate go file #701

merged 5 commits into from
Jan 20, 2017

Conversation

couling
Copy link
Contributor

@couling couling commented Jan 19, 2017

Attachments are set to be applied to more things within gitea. They have already been applied to releases.

In this PR I've spun them into separate files instead of being burred in issue.go. This will make it easier for future maintainers to work with.

@lunny lunny added this to the 1.1.0 milestone Jan 20, 2017
@@ -0,0 +1,73 @@
// Copyright 2014 The Gogs Authors. All rights reserved.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2017 The Gitea

@lunny
Copy link
Member

lunny commented Jan 20, 2017

Otherwise LGTM

@tboerger tboerger added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jan 20, 2017
@appleboy
Copy link
Member

Otherwise LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 20, 2017
@bkcsoft
Copy link
Member

bkcsoft commented Jan 20, 2017

@lunny I updated the copyright year, just wait for the build to pass

@bkcsoft bkcsoft merged commit 1610b9f into go-gitea:master Jan 20, 2017
@tboerger tboerger added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Feb 26, 2017
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants