Reject duplicate access token name #7135
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lunny
requested changes
Jun 6, 2019
| // AccessTokenByNameExists checks if a token name has been used already | ||
| // by a user. | ||
| func AccessTokenByNameExists(token *AccessToken) bool { | ||
| exists, _ := x.Get(token) |
There was a problem hiding this comment.
I think
x.Table("token").Where("name=?", tokenName).Exist()is better.
GiteaBot
added
the
lgtm/need 2
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 months. Thank you for your contributions. |
lunny
added
the
issue/confirmed
|
@adelowo whats the state? |
|
Yikes. Will try to prepare this for 1.11 |
|
@adelowo Can I take this too? |
|
Yes. |
|
new PR can be found here: #10994 |
|
Thanks. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have run into cases where I have multiple tokens with the same name and
it becomes hard to find out which one is no longer being used, so it can be deleted