Skip to content

Update css #7240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 18, 2019
Merged

Update css #7240

merged 1 commit into from
Jun 18, 2019

Conversation

zeripath
Copy link
Contributor

@zeripath zeripath commented Jun 18, 2019

Remove -o-tab-size selectors from generated tab-sze-* css

Remove -o-tab-size selectors from tab-sze-1 css
@zeripath zeripath added this to the 1.9.0 milestone Jun 18, 2019
@apricote
Copy link
Contributor

For reference: https://caniuse.com/#search=tab-size

Only active browser that still requires the -o- prefix is Opera Mini with ~1.43% global market share.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jun 18, 2019
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jun 18, 2019
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 18, 2019
@techknowlogick techknowlogick merged commit 954d24c into go-gitea:master Jun 18, 2019
@zeripath zeripath deleted the fix-css branch June 18, 2019 14:18
@silverwind
Copy link
Member

silverwind commented Jun 18, 2019

These prefixes are generated by autoprefixer based on this browserslist:

gitea/package.json

Lines 11 to 15 in 392fe6c

"browserslist": [
"> 1%",
"last 2 firefox versions",
"last 2 safari versions",
"ie 11"

I think this change here will not survive make css. To exclude a browser with 1.43% market share, I thing you could just change > 1% to > 1.5% and then run make css again.

@zeripath
Copy link
Contributor Author

@silverwind these changes are due to make css.

I'm happy if you want to restore this by changing package JSON though.

@silverwind
Copy link
Member

silverwind commented Jun 18, 2019

Indeed, I see it too now after reinstalling node_modules. I guess something must've changed further down in the dependency tree and I think it may actually be unintentional so those -o-tab-size may come back eventually. Locking dependencies will solve this kind of issues, I will soon have something ready to reintroduce a lockfile.

@zeripath
Copy link
Contributor Author

Congratulations on your maintainership btw!

jeffliu27 pushed a commit to jeffliu27/gitea that referenced this pull request Jul 18, 2019
Remove -o-tab-size selectors from tab-sze-1 css
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants