Fixes #7152 - Allow create/update/delete message to be empty, use default message

[richmahn]

Fixed #7152 - the swagger comment for the "message" field for the API request for Create/Update/Delete says to be optional, but failed if not supplied. Now, like the web interface, uses a default message ("Add file.txt", "Update file.txt" and "Delete `file.txt" respectively) like the web edit/delete interface does.

[codecov-io]

Codecov Report

Merging #7324 into master will increase coverage by <.01%.
The diff coverage is 78.57%.

@@            Coverage Diff            @@
##           master   #7324      +/-   ##
=========================================
+ Coverage    41.2%   41.2%   +<.01%     
=========================================
  Files         464     464              
  Lines       62938   62952      +14     
=========================================
+ Hits        25932   25938       +6     
- Misses      33612   33622      +10     
+ Partials     3394    3392       -2

Impacted Files	Coverage Δ
routers/api/v1/repo/file.go	69.08% <100%> (+0.88%)	⬆️
modules/repofiles/delete.go	52.73% <25%> (-0.79%)	⬇️
models/unit.go	62.16% <0%> (-5.41%)	⬇️
modules/log/event.go	64.61% <0%> (-1.03%)	⬇️
routers/repo/view.go	42.23% <0%> (-1.02%)	⬇️
modules/repofiles/file.go	83.33% <0%> (+3.12%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 462284e...fcc67ba. Read the comment docs.

[lunny]

The message could be saved on locale file so that users could define it themselves.

[richmahn]

@lunny Don't quite understand what you are saying. It uses the locale text like the web interface does.

[lunny]

@richmahn I mean we can use a translated message here. This will not block this PR.

Message: ctx.Tr("my language message")

[richmahn]

Why worry about translating a message in the integration test?

[richmahn]

Unless you were just showing that as an example, but with GitHub there is no translation done with commit messages. But right, not the issue addressed by this PR, as it is just giving the default editor.repo.add, editor.repo.update, editor.repo.delete messages if message is empty.

[zeripath]

I agree with @richmahn I don't think we should be trying to translate messages in the integration tests.

[lunny]

@richmahn Oh. it's a test file. Ignore my words above.

[richmahn]

I think a message should never be translated, but as the user intended. Only when it is auto-generated should it be translated. There may be a problem to as what if for some reason they actually wanted to write something like "template" or "home" which would get translated to "Template" or "Home" from our locale_en-US.ini file... while not a big change, it would boggle them why the message is getting uppercased.