Update CONTRIBUTING.md with information about DCO #7397
Conversation
| @@ -77,7 +77,7 @@ Here's how to run the test suite: | |||
| creates (a default AWS or GCE disk size won't work -- see | |||
| [#6243](https://github.com/go-gitea/gitea/issues/6243)). | |||
| - Change into the base directory of your copy of the gitea repository, | |||
| and run `drone exec --local --build-event pull_request`. | |||
| and run `drone exec --event pull_request`. | |||
There was a problem hiding this comment.
This line is unrelated to this PR, but as it is small rather than open a second PR for just this I have included here. If there is opposition to including this line in this PR please comment here and I will open a second PR for this line.
There was a problem hiding this comment.
I think there is an open issue related to that. I will look into it.
There was a problem hiding this comment.
It was closed by an other PR but this one complete it #7350
GiteaBot
added
the
lgtm/need 2
GiteaBot
added
lgtm/need 1
|
The build failure |
|
Otherwise lgtm |
Co-Authored-By: zeripath <[email protected]>
CONTRIBUTING.md
Outdated
| If you set your `user.name` and `user.email` git configs, you can add the | ||
| line to the end of your commit automatically with `git commit -s`. | ||
|
|
||
| We assume in good faith that the information you provide is legally biding. |
There was a problem hiding this comment.
| We assume in good faith that the information you provide is legally biding. | |
| We assume in good faith that the information you provide adheres to the [DCO](DCO), and won't request more personal information than provided for contributions. |
Not sure if this change makes sense with the DCO, but also we do allow pseudonyms and we probably aren't assuming they are 100% legally binding (and in many cases as the contributions aren't on a large scale to wonder if they were taken from anywhere else). Also I think with the information above most people who don't mind will do the sign off with legal name as they do now and people who don't want to won't
GiteaBot
added
lgtm/done
Codecov Report
@@ Coverage Diff @@
## master #7397 +/- ##
==========================================
- Coverage 41.23% 41.22% -0.01%
==========================================
Files 469 469
Lines 63602 63602
==========================================
- Hits 26224 26223 -1
+ Misses 33959 33958 -1
- Partials 3419 3421 +2
Continue to review full report at Codecov.
|
* Update CONTRIBUTING.md with information about DCO References: go-gitea#7389 More information: https://about.gitlab.com/handbook/marketing/community-relations/code-contributor-program/#developer-certificate-of-origin-dco * Update CONTRIBUTING.md Co-Authored-By: zeripath <[email protected]>
References: #7389
More information: https://about.gitlab.com/handbook/marketing/community-relations/code-contributor-program/#developer-certificate-of-origin-dco