Skip to content

Bug fixes and unit tests for models/webhook #751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 25, 2017

Conversation

ethantkoenig
Copy link
Member

Unit tests for models/webhook.go, and fixes a SQL bug in GetActiveWebhooksByRepoID()

@lunny lunny added this to the 1.1.0 milestone Jan 25, 2017
@lunny lunny added type/bug type/enhancement An improvement of existing functionality labels Jan 25, 2017
@lunny
Copy link
Member

lunny commented Jan 25, 2017

LGTM

@tboerger tboerger added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jan 25, 2017
@lunny lunny added type/testing and removed type/enhancement An improvement of existing functionality labels Jan 25, 2017
@appleboy
Copy link
Member

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 25, 2017
@lunny lunny merged commit 0934d1b into go-gitea:master Jan 25, 2017
@ethantkoenig ethantkoenig deleted the tests/webhook branch January 25, 2017 21:38
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug type/testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants