Skip to content

Fixed ineffectual assignments #7555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 22, 2019
Merged

Conversation

muesli
Copy link
Contributor

@muesli muesli commented Jul 21, 2019

Don't assign values we never use.

Don't assign values we never use.
@codecov-io
Copy link

codecov-io commented Jul 21, 2019

Codecov Report

Merging #7555 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7555      +/-   ##
==========================================
+ Coverage   41.24%   41.25%   +<.01%     
==========================================
  Files         469      469              
  Lines       63617    63616       -1     
==========================================
+ Hits        26239    26243       +4     
+ Misses      33955    33951       -4     
+ Partials     3423     3422       -1
Impacted Files Coverage Δ
routers/user/setting/security_twofa.go 15.58% <ø> (-0.55%) ⬇️
models/git_diff.go 68.34% <100%> (ø) ⬆️
models/repo_list.go 72.08% <0%> (-1.02%) ⬇️
routers/repo/view.go 43.25% <0%> (+1.01%) ⬆️
modules/process/manager.go 81.15% <0%> (+4.34%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a96503...b64c342. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jul 21, 2019
@techknowlogick techknowlogick added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Jul 22, 2019
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jul 22, 2019
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jul 22, 2019
@lunny lunny merged commit b0cd3b8 into go-gitea:master Jul 22, 2019
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants