Skip to content

fix xorm NewSession uncorrected usages #774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 27, 2017
Merged

fix xorm NewSession uncorrected usages #774

merged 1 commit into from
Jan 27, 2017

Conversation

lunny
Copy link
Member

@lunny lunny commented Jan 27, 2017

If x.NewSession() be called, sess.Close() must be called after that.

@lunny lunny added the type/bug label Jan 27, 2017
@lunny lunny added this to the 1.1.0 milestone Jan 27, 2017
@lunny lunny added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Jan 27, 2017
@Bwko
Copy link
Member

Bwko commented Jan 27, 2017

Trusted LGTM

@tboerger tboerger added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jan 27, 2017
@appleboy
Copy link
Member

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 27, 2017
@lunny lunny merged commit bb5a6b7 into go-gitea:master Jan 27, 2017
@lunny lunny deleted the lunny/fix_xorm_session branch April 19, 2017 05:43
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@appleboy appleboy appleboy approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.
4 participants
@lunny @Bwko @appleboy @tboerger