Skip to content

Unit tests and bug fix for models/org #776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 28, 2017

Conversation

ethantkoenig
Copy link
Member

Same changes as the now-closed #771; I accidentally deleted the branch on my fork, so I had to reissue the PR.

Fixes a SQL bug in CountRepos(), removes unused functions from models/org.go, and remove a unneeded load from database in RemoveOrgUser().

@strk
Copy link
Member

strk commented Jan 28, 2017

LGTM
@ethantkoenig you're doing a great job here with testcases, thank you so much !

@tboerger tboerger added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jan 28, 2017
@andreynering
Copy link
Contributor

LGTM
Yep, we are advancing fast with testing. 🎉

@appleboy
Copy link
Member

LGTM. Good Job

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 28, 2017
@andreynering andreynering merged commit abf3fbf into go-gitea:master Jan 28, 2017
@lunny lunny added this to the 1.1.0 milestone Jan 29, 2017
@ethantkoenig ethantkoenig deleted the tests/org branch January 30, 2017 01:53
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants