Skip to content

Display error as string but not bytes #7780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 7, 2019

Conversation

lunny
Copy link
Member

@lunny lunny commented Aug 7, 2019

As title

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Aug 7, 2019
Co-Authored-By: Antoine GIRARD <[email protected]>
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Aug 7, 2019
@codecov-io
Copy link

Codecov Report

Merging #7780 into master will increase coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7780      +/-   ##
==========================================
+ Coverage   41.32%   41.32%   +<.01%     
==========================================
  Files         474      474              
  Lines       63837    63837              
==========================================
+ Hits        26379    26380       +1     
  Misses      34019    34019              
+ Partials     3439     3438       -1
Impacted Files Coverage Δ
routers/repo/http.go 35.06% <0%> (ø) ⬆️
modules/log/event.go 64.61% <0%> (-1.03%) ⬇️
modules/process/manager.go 81.15% <0%> (+4.34%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 714dcf9...ba7b28d. Read the comment docs.

@lafriks lafriks merged commit b16be15 into go-gitea:master Aug 7, 2019
@lunny lunny deleted the lunny/display_error_string branch August 8, 2019 03:27
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/miscellaneous
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants