Skip to content

Fix newline in Unlicense #8182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix newline in Unlicense #8182

wants to merge 1 commit into from

Conversation

Uthar
Copy link

@Uthar Uthar commented Sep 15, 2019

This removes an extra newline.

@codecov-io
Copy link

Codecov Report

Merging #8182 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8182      +/-   ##
==========================================
+ Coverage   41.83%   41.84%   +<.01%     
==========================================
  Files         482      482              
  Lines       64613    64613              
==========================================
+ Hits        27033    27036       +3     
+ Misses      34109    34108       -1     
+ Partials     3471     3469       -2
Impacted Files Coverage Δ
models/repo_list.go 73.17% <0%> (-0.98%) ⬇️
models/repo_indexer.go 70.15% <0%> (+1.93%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a8e299...4d3463d. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Sep 15, 2019
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Sep 15, 2019
@lafriks
Copy link
Member

lafriks commented Sep 15, 2019

Is this change from upstream?

techknowlogick
techknowlogick requested changes Sep 15, 2019
View reviewed changes
Copy link
Member

@techknowlogick techknowlogick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for PR. These are generated from an upstream source of https://github.com/spdx/license-list-data

Please submit your changes to them first.

@techknowlogick techknowlogick added the status/blocked This PR cannot be merged yet, i.e. because it depends on another unmerged PR label Sep 15, 2019
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 27, 2019
zeripath added a commit to zeripath/gitea that referenced this pull request Oct 30, 2019
@zeripath
Update licenses
ebd104a 
Replaces go-gitea#8182
@zeripath zeripath mentioned this pull request Oct 30, 2019
Merged
zeripath added a commit that referenced this pull request Oct 30, 2019
@zeripath
Update licenses (#8752)
bda70b8 
Replaces #8182
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@techknowlogick techknowlogick techknowlogick requested changes

@guillep2k guillep2k guillep2k approved these changes

@6543 6543 6543 approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. status/blocked This PR cannot be merged yet, i.e. because it depends on another unmerged PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Uthar @codecov-io @lafriks @techknowlogick @guillep2k @6543 @GiteaBot