Skip to content

Extract actions on deletereleasebyid from models to release service #8219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Sep 30, 2019
Merged

Extract actions on deletereleasebyid from models to release service #8219

merged 6 commits into from
Sep 30, 2019

Conversation

lunny
Copy link
Member

@lunny lunny commented Sep 18, 2019

As title.

@lunny lunny added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Sep 18, 2019
lafriks
lafriks requested changes Sep 18, 2019
View reviewed changes
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Sep 18, 2019
@lunny lunny force-pushed the lunny/move_release branch from 70c2ea9 to eb912a0 Compare September 25, 2019 00:56
@codecov-io
Copy link

codecov-io commented Sep 25, 2019 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@ecd4bfd). Click here to learn what that means.
The diff coverage is 27.86%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #8219   +/-   ##
=========================================
  Coverage          ?   41.55%           
=========================================
  Files             ?      495           
  Lines             ?    65405           
  Branches          ?        0           
=========================================
  Hits              ?    27180           
  Misses            ?    34715           
  Partials          ?     3510
Impacted Files Coverage Δ
routers/api/v1/repo/release.go 44.94% <0%> (ø)
models/release.go 52.6% <0%> (ø)
models/attachment.go 51% <0%> (ø)
routers/repo/release.go 33.9% <0%> (ø)
services/release/release.go 39.04% <32.07%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ecd4bfd...0352418. Read the comment docs.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Sep 25, 2019
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Sep 30, 2019
@lunny
Copy link
Member Author

lunny commented Sep 30, 2019

make L-G-T-M work

@lunny lunny merged commit 3249c0c into go-gitea:master Sep 30, 2019
@lunny lunny deleted the lunny/move_release branch November 18, 2020 04:35
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lafriks lafriks lafriks approved these changes

@guillep2k guillep2k guillep2k approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lunny @codecov-io @lafriks @guillep2k @GiteaBot