[docs] Docker build - ZeroMQ dependency for Jupyter #8262
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lafriks
approved these changes
Sep 23, 2019
GiteaBot
added
the
lgtm/need 1
Codecov Report
@@ Coverage Diff @@
## master #8262 +/- ##
=======================================
Coverage 41.55% 41.55%
=======================================
Files 492 492
Lines 65355 65355
=======================================
Hits 27155 27155
Misses 34704 34704
Partials 3496 3496Continue to review full report at Codecov.
|
techknowlogick
requested changes
Sep 24, 2019
Co-Authored-By: techknowlogick <[email protected]>
lunny
approved these changes
Sep 26, 2019
GiteaBot
added
lgtm/done
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per #7970, the External Renders documentation includes a Docker example which is no longer functional.
The scope of this PR is a documentation fix for the example Dockerfile, to:
Able to reproduce the issue & fix as identified by @Th3Whit3Wolf - without handing the ZeroMQ dependency jupyter will not build.