Skip to content

Add 'make revive' to instructions for checking code #8314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 29, 2019
Merged

Add 'make revive' to instructions for checking code #8314

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
56dc2e8
Add 'make revive' to instructions for checking code
davidsvantesson Sep 29, 2019
462fbec
lint is deprecated. Denote revive +vet as code analysis in continuous…
davidsvantesson Sep 29, 2019
a8eb438
Merge branch 'master' into patch-2
sapk Sep 29, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions docs/content/doc/advanced/hacking-on-gitea.en-us.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,10 +108,10 @@ and look at our
[`.drone.yml`](https://github.com/go-gitea/gitea/blob/master/.drone.yml) to see
how our continuous integration works.

### Formatting, linting, vetting and spell-check
### Formatting, code analysis and spell check

Our continous integration will reject PRs that are not properly formatted, fail
linting, vet or spell-check.
code analysis or spell check.

You should format your code with `go fmt` using:

Expand All @@ -130,10 +130,10 @@ You should run the same version of go that is on the continuous integration
server as mentioned above. `make fmt-check` will only check if your `go` would
format differently - this may be different from the CI server version.

You should lint, vet and spell-check with:
You should run revive, vet and spell-check on the code with:

```bash
make vet lint misspell-check
make revive vet misspell-check
```

### Updating CSS
Expand Down