test: Add user mail testing. #833
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
tboerger
added
the
lgtm/need 1
ethantkoenig
suggested changes
Feb 3, 2017
| Email: "[email protected]", | ||
| IsActivated: true, | ||
| } | ||
| assert.NoError(t, AddEmailAddresses(emails)) |
There was a problem hiding this comment.
Not to be nitpicky, but this function tests both AddEmailAddress(..) and AddEmailAddresses(..). Could we split it into two tests: TestAddEmailAddress and TestAddEmailAddresses?
| UID: int64(2), | ||
| Email: "[email protected]", | ||
| } | ||
| assert.NoError(t, DeleteEmailAddresses(emails)) |
|
@appleboy A couple small changes, then it will Look-Good-To-Me |
|
@ethantkoenig Waiting build result. |
|
LGTM |
tboerger
added
lgtm/done
ethantkoenig
approved these changes
Feb 3, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as title.
cc @lunny @ethantkoenig