Skip to content

Refactor editorconfig middleware #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 5, 2016
Merged

Refactor editorconfig middleware #84

merged 1 commit into from
Nov 5, 2016

Conversation

andreynering
Copy link
Contributor

#59 was merged just few minutes before I could push a refactor for something @bkcsoft suggested. 😉

@strk
Copy link
Member

strk commented Nov 5, 2016

Please rebase, LGTM

@codecov-io
Copy link

codecov-io commented Nov 5, 2016

Current coverage is 2.18% (diff: 100%)

Merging #84 into master will not change coverage

@@            master       #84   diff @@
========================================
  Files           31        31          
  Lines         7508      7508          
  Methods          0         0          
  Messages         0         0          
  Branches         0         0          
========================================
  Hits           164       164          
  Misses        7327      7327          
  Partials        17        17          

Powered by Codecov. Last update 91b589f...bd898a1

@andreynering andreynering added the type/enhancement An improvement of existing functionality label Nov 5, 2016
@tboerger
Copy link
Member

tboerger commented Nov 5, 2016

LGTM

@tboerger
Copy link
Member

tboerger commented Nov 5, 2016

Needs a rebase...

@tboerger tboerger added this to the 1.0.0 milestone Nov 5, 2016
@metalmatze metalmatze merged commit a0e54c0 into go-gitea:master Nov 5, 2016
@andreynering andreynering deleted the gitea/fix-500-on-invalid-editorconfig branch November 5, 2016 18:22
@lunny
Copy link
Member

lunny commented Nov 6, 2016

Perfect!

@tboerger tboerger added the lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. label Nov 29, 2016
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
tyroneyeh added a commit to tyroneyeh/gitea that referenced this pull request Aug 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/enhancement An improvement of existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants