Add import-styleguide to Contributing.md

[bkcsoft]

Question: should we group all code.gitea.io-packages together as local imports? (including code.gitea.io/sdk and code.gitea.io/git etc)

@go-gitea/maintainers (sorry for the ping-all, but I want everyones opinion on this 😉 )

[lunny]

I think we should group code.gitea.io-packages together as local imports. Otherwise LGTM

[appleboy]

Vote @lunny comment +1. Otherwise LGTM

[lunny]

Who is -@-lukad- ?

[lukad]

That would be me. Probably a typo.

[lunny]

Why continuous-integration/drone/push is failed?

[appleboy]

@lukad Sorry for mentioned you.

[andreynering]

I think we should group all code.gitea.io repos together:

import (
+  // stdlib
+  "encoding/json"
+  "fmt"
+
+  // local package
+  "code.gitea.io/gitea/models"
+  "code.gitea.io/sdk/gitea"
+
+  // external package
+  "github.com/foo/bar"
+  "gopkg.io/baz.v1"
+)

[lunny]

@andreynering yes, that's what I have commented.

[thehowl]

wouldn't it be better to use the plural instead of the singular? i.e. local packages and external packages

[lunny]

^

[bkcsoft]

Done :)

[thehowl]

I quickly hacked together a script that formats the code following the style guide :)

https://github.com/thehowl/giteafmt

[bkcsoft]

@thehowl Should I specify that you shouldn't include the comments?

But really nice project! 🎉

[bkcsoft]

@thehowl How do you handle localhost/foo/bar ? https://github.com/thehowl/giteafmt/blob/master/types.go#L19

[thehowl]

... yes you should have specified it :P

I'm gonna write A Beginner's Guide On How To Feel Dumb

[thehowl]

How do you handle localhost/foo/bar ?

I don't. I just quickly smashed together some code so that it worked with the Gitea repo, it's not meant to handle all the edge cases.

[bkcsoft]

Now it's specific 😆

[andreynering]

LGTM

[tboerger]

I don't have a strong opinion on that, but I'm getting with the majority