Skip to content

Documentation fix: Correct port range for cap_net_bind_service #9306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 9, 2019
Merged

Documentation fix: Correct port range for cap_net_bind_service #9306

merged 1 commit into from
Dec 9, 2019

Conversation

jrcutler
Copy link
Contributor

@jrcutler jrcutler commented Dec 9, 2019 •
edited
Loading

Correct port range for cap_net_bind_service.

@techknowlogick techknowlogick added the type/docs This PR mainly updates/creates documentation label Dec 9, 2019
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Dec 9, 2019
zeripath
zeripath approved these changes Dec 9, 2019
View reviewed changes
Copy link
Contributor

@zeripath zeripath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could add that you can use socket activation in systemd to pass in sockets with port <1024

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 9, 2019
@codecov-io
Copy link

Codecov Report

Merging #9306 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9306      +/-   ##
==========================================
- Coverage   41.19%   41.18%   -0.01%     
==========================================
  Files         559      559              
  Lines       73073    73073              
==========================================
- Hits        30100    30098       -2     
- Misses      39199    39202       +3     
+ Partials     3774     3773       -1
Impacted Files Coverage Δ
models/unit.go 62.16% <0%> (-5.41%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f0d7c0...f0a5e0c. Read the comment docs.

@techknowlogick techknowlogick merged commit 2d8a895 into go-gitea:master Dec 9, 2019
@jrcutler jrcutler deleted the patch-1 branch December 9, 2019 21:09
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@techknowlogick techknowlogick techknowlogick approved these changes

@zeripath zeripath zeripath approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/docs This PR mainly updates/creates documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jrcutler @codecov-io @techknowlogick @zeripath @GiteaBot