Skip to content

Fix notification page panic when add and remove comment #9337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 13, 2019
Merged

Fix notification page panic when add and remove comment #9337

merged 2 commits into from
Dec 13, 2019

Conversation

jaqra
Copy link
Contributor

@jaqra jaqra commented Dec 12, 2019

This pr fixes 500 internal server error on notifications page when someone add issue comment then remove it immediately

@codecov-io
Copy link

codecov-io commented Dec 12, 2019

Codecov Report

Merging #9337 into master will decrease coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9337      +/-   ##
==========================================
- Coverage   41.27%   41.26%   -0.02%     
==========================================
  Files         561      561              
  Lines       73439    73439              
==========================================
- Hits        30315    30305      -10     
- Misses      39332    39340       +8     
- Partials     3792     3794       +2
Impacted Files Coverage Δ
models/notification.go 66.37% <0%> (ø) ⬆️
services/pull/check.go 55.63% <0%> (-2.26%) ⬇️
models/repo_list.go 73.14% <0%> (-0.93%) ⬇️
models/pull.go 54.4% <0%> (-0.5%) ⬇️
models/repo.go 47.97% <0%> (-0.1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba1acf5...dae9fdb. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 12, 2019
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Dec 12, 2019
@lafriks
Copy link
Member

lafriks commented Dec 12, 2019

shouldn't notification just be removed on deleting comment?

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 13, 2019
@lunny lunny added the type/bug label Dec 13, 2019
@sapk sapk merged commit 27f68bc into go-gitea:master Dec 13, 2019
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants