Skip to content

test: command keys #9357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 15, 2019
Merged

test: command keys #9357

merged 3 commits into from
Dec 15, 2019

Conversation

sapk
Copy link
Member

@sapk sapk commented Dec 15, 2019

Investigating the keys command (to use it in docker to replace the authorized_keys file), I wrote some tests that could be useful to keep to ensure that the command is working well.

@codecov-io
Copy link

codecov-io commented Dec 15, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@6715677). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #9357   +/-   ##
=========================================
  Coverage          ?   41.37%           
=========================================
  Files             ?      567           
  Lines             ?    73577           
  Branches          ?        0           
=========================================
  Hits              ?    30445           
  Misses            ?    39330           
  Partials          ?     3802

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6715677...a457695. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 15, 2019
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Dec 15, 2019
@zeripath
Copy link
Contributor

I thought we were going to migrate to the internal SSH on docker because that's the only way to get rootless docker?

@sapk
Copy link
Member Author

sapk commented Dec 15, 2019

@zeripath I am for using internal ssh but I don't think that everyone are currently.

@sapk
Copy link
Member Author

sapk commented Dec 15, 2019

I will maybe propose a PR in this direction and see what happen 😄

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 15, 2019
@zeripath zeripath merged commit 8bea92c into go-gitea:master Dec 15, 2019
@sapk sapk deleted the test-keys-command branch December 15, 2019 22:10
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants